Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#46 Urbanisme evolutions, updated layer addition & feature highlighting mechanism #43

Conversation

alexander-fedorenko
Copy link
Collaborator

@alexander-fedorenko alexander-fedorenko commented Feb 17, 2022

Description

This PR suggests changes to resolve issues mentioned in #42:

  • Urbanisme layer will not appear in TOC
  • Identify tool will be disabled if Urbanisme toolbar is active. NRU & ADS tools will work regardless of added layers.
  • Activation of Identify tool via map toolbar will disable Urbanisme tool.
  • Activation of hover-based map info trigger in map settings will disable Urbanisme tool.
  • Activation of Urbanisme tool will switch map info trigger to click.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#42

What is the new behavior?
As per description

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@alexander-fedorenko
Copy link
Collaborator Author

WIP, ammending tests.

Removed unneded reprojections, data is reprojected only when it needs to be displayed on the map.
…ccording to the changed approach urbanisme layer storage and highlighting.
Ammended existing tests and added new tests for changes in sigrennesmetropole#42
@alexander-fedorenko alexander-fedorenko changed the title #46 Urbanisme evolutions, updated layer addition & feature highlighting mechanism [WIP, ammending tests] #46 Urbanisme evolutions, updated layer addition & feature highlighting mechanism Feb 20, 2022
@alexander-fedorenko
Copy link
Collaborator Author

@offtherailz please review when convenient. Thanks!

@offtherailz offtherailz merged commit 8487f4a into sigrennesmetropole:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants